linux-kernel - Re: [PATCH] kconfig.h: use already defined macros for IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARC4NVuSwUDh8aU__9shtP_7a1q0A6vVdKcevN-yqZZWA@mail.gmail.com>
Date:	Tue, 14 Jun 2016 15:01:00 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Nicolas Pitre <nicolas.pitre@...aro.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Simek <michal.simek@...inx.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Michal Marek <mmarek@...e.cz>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] kconfig.h: use already defined macros for IS_REACHABLE() define

Hi Nicolas,

2016-06-07 7:03 GMT+09:00 Nicolas Pitre <nicolas.pitre@...aro.org>:
> On Tue, 7 Jun 2016, Masahiro Yamada wrote:
>
>> Because config_enabled() is so useful,
>> maybe people tend to abuse it.
>>
>> I see one case where config_enabled() is used
>> for a non-config macro.
>>
>> #define __EXPORT_SYMBOL(sym, sec) \
>>            __cond_export_sym(sym, sec, config_enabled(__KSYM_##sym))
>
> Here the need is for a macro that returns 1 or 0 whether given
> symbol is defined or not, exactly as explained in the comment above the
> definition for config_enabled() which in itself has nothing to do with
> config.
>
> So maybe config_enabled() should be renamed to __is_defined() or
> similar, and then config_enabled() or its replacement defined in termps
> of it.

__is_defined() seems reasonable to me, so I've sent an updated series.





-- 
Best Regards
Masahiro Yamada