linux-kernel - Re: [PATCH v3] iio: stx104: Add GPIO support for the Apex Embedded Systems STX104

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 08:53:48 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] iio: stx104: Add GPIO support for the Apex Embedded
 Systems STX104

On Mon, Jun 13, 2016 at 3:06 PM, William Breathitt Gray
<vilhelm.gray@...il.com> wrote:

> The Apex Embedded Systems STX104 device features eight lines of digital
> I/O (four digital inputs and four digital outputs). This patch adds GPIO
> support for these eight lines of digital I/O via GPIOLIB.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> ---
> Changes in v3:
>   - Revert v2 change; any arch should be able to select GPIOLIB
>   - Return -EINVAL when attempting to set a GPIO to a direction it
>     cannot be
>   - Call stx104_gpio_set to have an initial value when setting a GPIO to
>     output direction

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij