linux-kernel - Re: [v2 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 15:24:56 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Charles Chiou <ch1102chiou@...il.com>
Cc:	kbuild-all@...org, jejb@...ux.vnet.ibm.com,
	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, linus.chen@...promise.com,
	grace.chang@...promise.com, victor.p@...mise.com,
	eva.cheng@...promise.com, charles.chiou@...promise.com,
	julian.calaby@...il.com, Paul <paul.lyu@...promise.com>
Subject: Re: [v2 PATCH 1/2] scsi:stex.c Support Pegasus 3 product

Hi,

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.7-rc3 next-20160609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Charles-Chiou/scsi-stex-c-Support-Pegasus-3-product/20160614-142621
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/scsi/stex.c: In function 'stex_handshake':
>> drivers/scsi/stex.c:1208:2: warning: 'scratch' may be used uninitialized in this function [-Wmaybe-uninitialized]
     memset(scratch, 0, scratch_size);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/scsi/stex.c:1111:10: note: 'scratch' was declared here
     __le32 *scratch;
             ^~~~~~~

vim +/scratch +1208 drivers/scsi/stex.c

0f3f6ee6 Ed Lin  2009-03-31  1192  			msleep(1);
0f3f6ee6 Ed Lin  2009-03-31  1193  		}
2a48e931 Charles 2016-06-14  1194  	} else {
2a48e931 Charles 2016-06-14  1195  		while ((readl(base + MAILBOX_BASE + MAILBOX_HNDSHK_STS)
2a48e931 Charles 2016-06-14  1196  		 & SS_STS_HANDSHAKE) == 0) {
2a48e931 Charles 2016-06-14  1197  			if (time_after(jiffies, before + MU_MAX_DELAY * HZ)) {
2a48e931 Charles 2016-06-14  1198  				printk(KERN_ERR DRV_NAME
2a48e931 Charles 2016-06-14  1199  					"(%s): no signature after handshake frame\n",
2a48e931 Charles 2016-06-14  1200  					pci_name(hba->pdev));
2a48e931 Charles 2016-06-14  1201  				ret = -1;
2a48e931 Charles 2016-06-14  1202  				break;
2a48e931 Charles 2016-06-14  1203  			}
2a48e931 Charles 2016-06-14  1204  			rmb();
2a48e931 Charles 2016-06-14  1205  			msleep(1);
2a48e931 Charles 2016-06-14  1206  		}
2a48e931 Charles 2016-06-14  1207  	}
9eb46d2a Ed Lin  2009-09-28 @1208  	memset(scratch, 0, scratch_size);
0f3f6ee6 Ed Lin  2009-03-31  1209  	msg_h->flag = 0;
2a48e931 Charles 2016-06-14  1210  
0f3f6ee6 Ed Lin  2009-03-31  1211  	return ret;
0f3f6ee6 Ed Lin  2009-03-31  1212  }
0f3f6ee6 Ed Lin  2009-03-31  1213  
0f3f6ee6 Ed Lin  2009-03-31  1214  static int stex_handshake(struct st_hba *hba)
0f3f6ee6 Ed Lin  2009-03-31  1215  {
0f3f6ee6 Ed Lin  2009-03-31  1216  	int err;

:::::: The code at line 1208 was first introduced by commit
:::::: 9eb46d2a08de537e14e92216bf18e7cb541d2f67 [SCSI] stex: add support for reset request from firmware

:::::: TO: Ed Lin <ed.lin@...mise.com>
:::::: CC: James Bottomley <James.Bottomley@...e.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (54771 bytes)