[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1465891117-18215-1-git-send-email-uvv.mail@gmail.com>
Date: Tue, 14 Jun 2016 09:58:37 +0200
From: "Vyacheslav V. Yurkov" <uvv.mail@...il.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org,
"Vyacheslav V. Yurkov" <uvv.mail@...il.com>
Subject: [PATCH] [RESEND] drivers/base dmam_declare_coherent_memory leaks
dmam_declare_coherent_memory doesn't take into account the return
value of dma_declare_coherent_memory, which leads to incorrect resource
handling
Signed-off-by: Vyacheslav V. Yurkov <uvv.mail@...il.com>
---
drivers/base/dma-mapping.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/base/dma-mapping.c b/drivers/base/dma-mapping.c
index d799662..f5d2132 100644
--- a/drivers/base/dma-mapping.c
+++ b/drivers/base/dma-mapping.c
@@ -198,10 +198,13 @@ int dmam_declare_coherent_memory(struct device *dev, phys_addr_t phys_addr,
rc = dma_declare_coherent_memory(dev, phys_addr, device_addr, size,
flags);
- if (rc == 0)
+ if (rc) {
devres_add(dev, res);
- else
+ rc = 0;
+ } else {
devres_free(res);
+ rc = -ENOMEM;
+ }
return rc;
}
--
1.8.4
Powered by blists - more mailing lists