linux-kernel - Re: [PATCH v13 05/10] arm64: Kprobes with single stepping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160614094559.51a7865fa30f3f31f6a70e37@kernel.org>
Date:	Tue, 14 Jun 2016 09:45:59 +0900
From:	Masami Hiramatsu <mhiramat@...nel.org>
To:	David Long <dave.long@...aro.org>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Huang Shijie <shijie.huang@....com>,
	James Morse <james.morse@....com>,
	Marc Zyngier <marc.zyngier@....com>,
	Pratyush Anand <panand@...hat.com>,
	Sandeepa Prabhu <sandeepa.s.prabhu@...il.com>,
	Will Deacon <will.deacon@....com>,
	William Cohen <wcohen@...hat.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Steve Capper <steve.capper@...aro.org>,
	Li Bin <huawei.libin@...wei.com>,
	Adam Buchbinder <adam.buchbinder@...il.com>,
	Alex Bennée <alex.bennee@...aro.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Christoffer Dall <christoffer.dall@...aro.org>,
	Daniel Thompson <daniel.thompson@...aro.org>,
	Dave P Martin <Dave.Martin@....com>,
	Jens Wiklander <jens.wiklander@...aro.org>,
	Jisheng Zhang <jszhang@...vell.com>,
	John Blackwood <john.blackwood@...r.com>,
	Mark Rutland <mark.rutland@....com>,
	Petr Mladek <pmladek@...e.com>,
	Robin Murphy <robin.murphy@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Vladimir Murzin <Vladimir.Murzin@....com>,
	Yang Shi <yang.shi@...aro.org>,
	Zi Shen Lim <zlim.lnx@...il.com>,
	yalin wang <yalin.wang2010@...il.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v13 05/10] arm64: Kprobes with single stepping support

On Mon, 13 Jun 2016 11:22:47 -0400
David Long <dave.long@...aro.org> wrote:

> On 06/13/2016 02:50 AM, Masami Hiramatsu wrote:
> > On Mon, 13 Jun 2016 00:10:29 -0400
> > David Long <dave.long@...aro.org> wrote:
> >
> >>>> ---
> >>>>    arch/arm64/Kconfig                      |   1 +
> >>>>    arch/arm64/include/asm/debug-monitors.h |   5 +
> >>>>    arch/arm64/include/asm/insn.h           |   4 +-
> >>>>    arch/arm64/include/asm/kprobes.h        |  60 ++++
> >>>>    arch/arm64/include/asm/probes.h         |  44 +++
> >>>>    arch/arm64/kernel/Makefile              |   1 +
> >>>>    arch/arm64/kernel/debug-monitors.c      |  18 +-
> >>>>    arch/arm64/kernel/kprobes-arm64.c       | 144 +++++++++
> >>>>    arch/arm64/kernel/kprobes-arm64.h       |  35 +++
> >>>>    arch/arm64/kernel/kprobes.c             | 526 ++++++++++++++++++++++++++++++++
> >>>
> >>> Not sure why kprobes.c and kprobes-arm64.c are splitted.
> >>>
> >>>
> >>
> >> This comes from the model of the arm32 kprobes code where handling of
> >> the low-level instruction simulation is implemented in separate files
> >> for 32-bit vs. thumb instructions.  It should make a little more sense
> >> in the future when additional instruction simulation code will hopefully
> >> be added for those instructions we cannot currently single-step
> >> out-of-line.  It also probably *could* be merged into one file.
> >
> > Hmm, at least the name of arch/arm64/kernel/kprobes-arm64.c is
> > meaningless. As we've done in x86, I think we can make it
> > arch/arm64/kernel/kprobes/decode-insn.{c,h}
> >
> 
> I've changed the name to kprobe-decode-insn.[hc], or do you feel 
> strongly the three kprobes source files in arch/arm64/kernel need their 
> own subdirectory?

Yes, especially when we start working on kprobes-on-ftrace support,
it is better to have a separate file for that.

Thank you!


-- 
Masami Hiramatsu <mhiramat@...nel.org>