linux-kernel - Re: [PATCH] USB: core: fix missing include <linux/usb/of.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614013401.GA24636@kroah.com>
Date:	Mon, 13 Jun 2016 18:34:01 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:	linux-kernel@...ts.codethink.co.uk, Arnd Bergmann <arnd@...db.de>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Alan Stern <stern@...land.harvard.edu>,
	Peter Chen <peter.chen@...escale.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: core: fix missing include <linux/usb/of.h>

On Tue, Jun 07, 2016 at 07:20:33PM +0100, Ben Dooks wrote:
> The helper function usb_of_get_child_node() is defined in the
> header <linux/usb/of.h> but this was not included. Fix the warning
> about usb_of_get_child_node() not being declared by adding the
> right include. Fixes:
> 
> drivers/usb/core/of.c:31:20: warning: symbol 'usb_of_get_child_node' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

Given that the kbuild robot broke with this patch, I'm not going to take
it...