linux-kernel - Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614100931.GJ1740@lahna.fi.intel.com>
Date:	Tue, 14 Jun 2016 13:09:31 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Bin Gao <bin.gao@...ux.intel.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>,
	Bin Gao <bin.gao@...el.com>
Subject: Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver

On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote:
> +static const struct platform_device_id pmic_gpio_id_table[] = {
> +	{ "bxt_wcove_gpio", },
> +};

Do you really need this?

> +
> +static struct platform_driver wcove_gpio_driver = {
> +	.probe = wcove_gpio_probe,
> +	.remove = wcove_gpio_remove,
> +	.driver = {
> +		.name = "wcove_gpio",
> +	},
> +	.id_table = pmic_gpio_id_table,

and this?

> +};
> +
> +module_platform_driver(wcove_gpio_driver);
> +
> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>");
> +MODULE_DESCRIPTION("Intel Whiskey Cove GPIO Driver");
> +MODULE_LICENSE("GPL v2");

You can add

MODULE_ALIAS("platform:wcove_gpio");

to get the module loaded automatically.