linux-kernel - Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3 idle states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 21:29:48 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Shreyas B Prabhu <shreyas@...ux.vnet.ibm.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	ego@...ux.vnet.ibm.com, mikey@...ling.org,
	linux-pm@...r.kernel.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
	maddy@...ux.vnet.ibm.com,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v6 10/11] cpuidle/powernv: Add support for POWER ISA v3
 idle states

On Tue, 2016-06-14 at 16:17 +0530, Shreyas B Prabhu wrote:

> 
> I ignored adding this check because this is part of initcall and we are
> unlikely to run out of memory at this state. But I'll add the check in
> next version.

Why do you malloc the u64 array and not the string pointer array ?
Shouldn't you either have both on stack or both allocated ?

Cheers,
Ben.