linux-kernel - Re: [PATCH v8 0/5] skb_array: array based FIFO for skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614135659.0cb9f2ff@redhat.com>
Date:	Tue, 14 Jun 2016 13:56:59 +0200
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Jason Wang <jasowang@...hat.com>,
	Eric Dumazet <eric.dumazet@...il.com>, davem@...emloft.net,
	netdev@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	kvm@...r.kernel.org, brouer@...hat.com
Subject: Re: [PATCH v8 0/5] skb_array: array based FIFO for skbs


On Mon, 13 Jun 2016 23:54:26 +0300 "Michael S. Tsirkin" <mst@...hat.com> wrote:
> 
> Jesper, Jason, I know that both of you tested this,
> please post Tested-by tags for whatever was tested.

Yes, I tested this via "external" kernel modules, not your framework.
I have verified that this V8 patchset is equivalent, to what I have in:
 https://github.com/netoptimizer/prototype-kernel/ (at 81ca09c2a945)

> changes since v7
> 	fix typos noticed by Jesper Brouer

You also fixed a missing _bh ... I verified you also included this fix ;-)
 https://github.com/netoptimizer/prototype-kernel/commit/24da4f495bb

> changes since v6
> 	resize implemented. peek/full calls are no longer lockless
> 
> 	replaced _FIELD macros with _CALL which invoke a function
> 	on the pointer rather than just returning a value
> 
> 	destroy now scans the array and frees all queued skbs
> 
> changes since v5
> 	implemented a generic ptr_ring api, and
> 		made skb_array a type-safe wrapper
> 	apis for taking the spinlock in different contexts
> 		following expected usecase in tun

Tested-by: Jesper Dangaard Brouer <brouer@...hat.com>

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer