linux-kernel - Re: [PATCH] mmc: Change the enhanced area related sysfs output format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614124100.GA1608@katana>
Date:	Tue, 14 Jun 2016 14:41:00 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Beata Baranowska <beatax.baranowska@...el.com>,
	ulf.hansson@...aro.org, aisheng.dong@....com,
	wsa+renesas@...g-engineering.com, gwendal@...omium.org,
	chaotian.jing@...iatek.com, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org, sebastianx.jarosz@...el.com,
	Chuanxiao Dong <chuanxiao.dong@...el.com>
Subject: Re: [PATCH] mmc: Change the enhanced area related sysfs output format

On Tue, Jun 14, 2016 at 01:36:11PM +0300, Adrian Hunter wrote:
> On 14/06/16 13:12, Wolfram Sang wrote:
> > On Tue, Jun 14, 2016 at 10:33:06AM +0200, Beata Baranowska wrote:
> >> From: Chuanxiao Dong <chuanxiao.dong@...el.com>
> >>
> >> When the enhanced area feature was not enabled, the related sysfs will 
> >> have -EINVAL(-22) value, so change the sysfs output format to display 
> >> the correct value.
> >>
> >> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@...el.com>
> > 
> > What about introducing attribute_group an use the is_visible callback
> > there, so they won't get displayed at all?
> > 
> 
> Except that it is an ABI:
> 
> 	Documentation/ABI/testing/sysfs-devices-mmc

And broken ever since if this patch is needed... that being said, I
don't really have a strong opinion on my suggestion. I see the file is
out there for >5 years.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)