linux-kernel - Re: [PATCH] arm64: dts: apm: Use lowercase consistently for hex constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160614125444.GA21266@localhost>
Date:	Tue, 14 Jun 2016 07:54:44 -0500
From:	Bjorn Helgaas <helgaas@...nel.org>
To:	Duc Dang <dhdang@....com>
Cc:	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Mark Rutland <mark.rutland@....com>,
	Devicetree List <devicetree@...r.kernel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH] arm64: dts: apm: Use lowercase consistently for hex
 constants

On Mon, Jun 13, 2016 at 07:33:59PM -0700, Duc Dang wrote:
> On Wed, Jun 8, 2016 at 12:48 PM, Rob Herring <robh@...nel.org> wrote:
> > On Mon, Jun 06, 2016 at 03:17:56PM -0500, Bjorn Helgaas wrote:
> >> The convention in these files is to use lowercase for "0x" prefixes and for
> >> the hex constants themselves, but a few changes didn't follow that
> >> convention, which makes the file annoying to read.
> >>
> >> Use lowercase consistently for the hex constants.  No functional change
> >> intended.
> >>
> >> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> >> ---
> >>  .../devicetree/bindings/net/apm-xgene-enet.txt     |    4 +-
> >>  arch/arm64/boot/dts/apm/apm-shadowcat.dtsi         |   40 ++++++++++----------
> >>  arch/arm64/boot/dts/apm/apm-storm.dtsi             |   36 +++++++++---------
> >>  3 files changed, 40 insertions(+), 40 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> >> index 05f705e3..e41b2d5 100644
> >> --- a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> >> +++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
> >> @@ -59,8 +59,8 @@ Example:
> >>               compatible = "apm,xgene-enet";
> >>               status = "disabled";
> >>               reg = <0x0 0x17020000 0x0 0xd100>,
> >> -                   <0x0 0X17030000 0x0 0X400>,
> >> -                   <0x0 0X10000000 0x0 0X200>;
> >> +                   <0x0 0x17030000 0x0 0x400>,
> >> +                   <0x0 0x10000000 0x0 0x200>;
> >>               reg-names = "enet_csr", "ring_csr", "ring_cmd";
> >>               interrupts = <0x0 0x3c 0x4>;
> >>               port-id = <0>;
> >> diff --git a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> >> index c569f76..9773687 100644
> >> --- a/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> >> +++ b/arch/arm64/boot/dts/apm/apm-shadowcat.dtsi
> >> @@ -106,9 +106,9 @@
> >>               interrupts = <1 9 0xf04>;       /* GIC Maintenence IRQ */
> >>               ranges = <0 0 0 0x79000000 0x0 0x800000>; /* MSI Range */
> >>               reg = <0x0 0x78090000 0x0 0x10000>,     /* GIC Dist */
> >> -                   <0x0 0x780A0000 0x0 0x20000>,     /* GIC CPU */
> >> -                   <0x0 0x780C0000 0x0 0x10000>,     /* GIC VCPU Control */
> >> -                   <0x0 0x780E0000 0x0 0x20000>;     /* GIC VCPU */
> >> +                   <0x0 0x780a0000 0x0 0x20000>,     /* GIC CPU */
> >> +                   <0x0 0x780c0000 0x0 0x10000>,     /* GIC VCPU Control */
> >> +                   <0x0 0x780e0000 0x0 0x20000>;     /* GIC VCPU */
> >>               v2m0: v2m@...0000 {
> >
> > Unit addresses should not have '0x' or leading 0s.
> >
> >>                       compatible = "arm,gic-v2m-frame";
> >>                       msi-controller;
> >> @@ -159,35 +159,35 @@
> >>                       msi-controller;
> >>                       reg = <0x0 0x90000 0x0 0x1000>;
> >>               };
> >> -             v2m10: v2m@...0000 {
> >> +             v2m10: v2m@...0000 {
> >
> > and here...
> 
> Thanks, Bjorn. Will you have time to post another version that
> addresses Rob's comment?

Sorry, I forgot to follow up on this.  I didn't understand Rob's comment,
because my patch only changed uppercase/lowercase.  I didn't add or remove
any '0x' or '0' prefixes.

>From the context, I infer that we should have "v2m10: v2m@...00" instead of
"v2m10: v2m@...0000".

I'll make a second patch that makes that change.  I do notice many other 
DTs that have similar constructs, e.g.,

  arch/arc/boot/dts/abilis_tb10x.dtsi:            spi0: spi@...E010000 {
  arch/arc/boot/dts/abilis_tb10x.dtsi:            spi1: spi@...E011000 {
  arch/arc/boot/dts/axc001.dtsi:          dw-apb-gpio@...000 {
  arch/arc/boot/dts/axc001.dtsi:          debug_uart: dw-apb-uart@...000 {
  ...

Maybe more opportunities for cleanup?

Bjorn