linux-kernel - Re: [PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1606141018530.1574-100000@iolanthe.rowland.org>
Date:	Tue, 14 Jun 2016 10:21:59 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Roger Quadros <rogerq@...com>
cc:	peter.chen@...escale.com, <balbi@...nel.org>, <tony@...mide.com>,
	<gregkh@...uxfoundation.org>, <dan.j.williams@...el.com>,
	<mathias.nyman@...ux.intel.com>, <Joao.Pinto@...opsys.com>,
	<sergei.shtylyov@...entembedded.com>, <jun.li@...escale.com>,
	<grygorii.strashko@...com>, <yoshihiro.shimoda.uh@...esas.com>,
	<robh@...nel.org>, <nsekhar@...com>, <b-liu@...com>,
	<joe@...ches.com>, <linux-usb@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v10 03/14] usb: hcd.h: Add OTG to HCD interface

On Tue, 14 Jun 2016, Roger Quadros wrote:

> +Alan
> 
> On 10/06/16 16:07, Roger Quadros wrote:
> > The OTG core will use struct otg_hcd_ops to interface
> > with the HCD (Host Controller Driver).
> > 
> > The main purpose of this interface is to avoid directly
> > calling HCD APIs from the OTG core as they
> > wouldn't be defined in the built-in symbol table if
> > CONFIG_USB is m.
> > 
> > Signed-off-by: Roger Quadros <rogerq@...com>
> > Acked-by: Peter Chen <peter.chen@....com>
> > ---
> >  include/linux/usb/hcd.h | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> > index 66fc137..7729c1f 100644
> > --- a/include/linux/usb/hcd.h
> > +++ b/include/linux/usb/hcd.h
> > @@ -400,6 +400,30 @@ struct hc_driver {
> >  
> >  };
> >  
> > +/**
> > + * struct otg_hcd_ops - Interface between OTG core and HCD
> > + *
> > + * Provided by the HCD core to allow the OTG core to interface with the HCD

Add:  * in case the OTG core is built-in and the HCD core is built as a module.

Otherwise, for patches 1, 3, and 12:

Acked-by: Alan Stern <stern@...land.harvard.edu>

Alan Stern