linux-kernel - Re: [PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOiHx=kmkkMyHQQ5wm7J7UGgrsgpMv6dcBxHhwv4yFUc6zzwDw@mail.gmail.com>
Date:	Tue, 14 Jun 2016 16:38:47 +0200
From:	Jonas Gorski <jogo@...nwrt.org>
To:	Álvaro Fernández Rojas <noltari@...il.com>
Cc:	MIPS Mailing List <linux-mips@...ux-mips.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Florian Fainelli <f.fainelli@...il.com>,
	Kevin Cernekee <cernekee@...il.com>,
	Rob Herring <robh@...nel.org>, Simon Arlott <simon@...e.lp0.eu>
Subject: Re: [PATCH 1/6] MIPS: BMIPS: add missing console to bcm96358nb4ser

Hi Álvaro,

On 13 June 2016 at 09:38, Álvaro Fernández Rojas <noltari@...il.com> wrote:
> Console definition is needed in order to avoid a warning in earlycon to
> console transition.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> ---
>  arch/mips/boot/dts/brcm/bcm96358nb4ser.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts
> index f412117..702eae2 100644
> --- a/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts
> +++ b/arch/mips/boot/dts/brcm/bcm96358nb4ser.dts

Unfortunately I haven't seen this earlier, but please don't name the
dts file bcm9* unless it's an actual reference/eval board from
Broadcom.

A more sensible name would be neufbox4-sercom.dts or
bcm6358-neufbox4-sercom.dts.


Regards
Jonas