linux-kernel - Re: [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160614145258.GD1868@techsingularity.net>
Date:	Tue, 14 Jun 2016 15:52:58 +0100
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [PATCH 06/27] mm, vmscan: Make kswapd reclaim in terms of nodes

On Sun, Jun 12, 2016 at 05:33:24PM +0800, Hillf Danton wrote:
> > -	/*
> > -	 * We put equal pressure on every zone, unless one zone has way too
> > -	 * many pages free already. The "too many pages" is defined as the
> > -	 * high wmark plus a "gap" where the gap is either the low
> > -	 * watermark or 1% of the zone, whichever is smaller.
> > -	 */
> > -	balance_gap = min(low_wmark_pages(zone), DIV_ROUND_UP(
> > -			zone->managed_pages, KSWAPD_ZONE_BALANCE_GAP_RATIO));
> > +		nr_to_reclaim += max(high_wmark_pages(zone), SWAP_CLUSTER_MAX);
> > +	}
> 
> Missing sc->nr_to_reclaim = nr_to_reclaim; ?
> 

Yes. It may explain why I saw lower than expected kswapd in more
detailed tests recently. Thanks.

-- 
Mel Gorman
SUSE Labs