linux-kernel - Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 17:29:11 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	David Cohen <david.a.cohen@...ux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH v1 1/1] x86/platform/intel-mid: Add Power Management Unit
 driver


* Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Tue, 2016-06-14 at 12:43 +0200, Ingo Molnar wrote:
> > * Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > 
> > > Add Power Management Unit driver to handle power states of South
> > > Complex
> > > devices on Intel Tangier. In the future it might be expanded to
> > > cover North
> > > Complex devices as well.
> > > 
> > > With this driver the power state of the host controllers such as
> > > SPI, I2C,
> > > UART, eMMC, and DMA would be managed.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > ---
> > >  arch/x86/include/asm/intel-mid.h     |   8 +
> > >  arch/x86/pci/intel_mid_pci.c         |  35 +++-
> > >  arch/x86/platform/intel-mid/Makefile |   2 +-
> > >  arch/x86/platform/intel-mid/pmu.c    | 392
> > > +++++++++++++++++++++++++++++++++++
> > >  drivers/pci/Makefile                 |   3 +
> > >  drivers/pci/pci-mid.c                |  77 +++++++
> > >  6 files changed, 515 insertions(+), 2 deletions(-)
> > >  create mode 100644 arch/x86/platform/intel-mid/pmu.c
> > >  create mode 100644 drivers/pci/pci-mid.c
> > 
> > So this collides with perf's 'PMU' naming massively. Can we pick
> > another name 
> > before hillarious kernel-wide confusion spreads?
> > 
> > how about intel/mid/pm.c plus renaming all the pmu* internal names to
> > pm*?
> > 
> > We could call it 'power management interface', and in a single line
> > mention that 
> > this is also a 'Power Management Unit' in Intel-speak?
> 
> In the TRM it's called Power Management Unit, though once or twice in some 
> documents as Power Management Controller. I actually woudn't like to use PMC 
> abbreviation to not be confused with pmc_atom.c and many other variation of 
> existing PMC drivers of other Intel platforms.
> 
> PM* as a prefix might be too short to conflict with Power Management framework 
> in the kernel. P-Unit (punit*) is existing part in SoC which will have its own 
> driver in the future, so, can't use it either.
> 
> pwr*, pwrmu*, scpmu* (as of South Complex Power Management Unit) — one of them?

'pwr' certainly sounds good to me! PWMU perhaps?

Thanks,

	Ingo