linux-kernel - Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 09:48:06 -0600
From:	Logan Gunthorpe <logang@...tatee.com>
To:	Allen Hubbe <Allen.Hubbe@....com>,
	'Allen Hubbe' <allenbh@...il.com>
Cc:	'Jon Mason' <jdmason@...zu.us>,
	'Dave Jiang' <dave.jiang@...el.com>,
	'Shuah Khan' <shuahkh@....samsung.com>,
	'Sudip Mukherjee' <sudipm.mukherjee@...il.com>,
	'Arnd Bergmann' <arnd@...db.de>, linux-kernel@...r.kernel.org,
	linux-ntb@...glegroups.com, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs



On 14/06/16 09:45 AM, Allen Hubbe wrote:
> 
> Feel free to disregard my suggestion above.  I hope my comment has not cost you too much time.
> 
> The way you have written it already, and used it in the self-test script is much more concise.
> 
>>> + * root@...f# echo > $DBG_DIR/link
> 
> Acked-by: Allen.Hubbe@....com
> 
> 
> 
> Eventually, I think it would be useful to let ntb_tool enable and disable the link.  In that case, it might also be useful in a test script to wait for link down, not just link up.
> 
> What about this:
> 
> # Wait for the link to be up or down
> root@...f# echo 1 > $DBG_DIR/link
> root@...f# echo 0 > $DBG_DIR/link
> 
> It need not be a part of this patch, but eventually:
> 
> # Enable or disable the link
> root@...f# echo 1 > $DBG_DIR/link_ctrl
> root@...f# echo 0 > $DBG_DIR/link_ctrl
> 
> # Reading the link_ctrl file can also give the link status
> root@...f# cat $DBG_DIR/link_ctrl
> 
> Finally, I wonder if the file called "link" in this patch should be called "link_wait" or similar, so its purpose is obviously not for enabling and disabling the link.
> 

Actually I've already implemented something similar to your original
suggestion. I'll be submitting a v2 of this set shortly.

Logan