linux-kernel - Re: [PATCH] mfd: max77620: Fix FPS switch statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e25e615-e2db-ad9b-2aad-cc44599c58d1@nvidia.com>
Date:	Tue, 14 Jun 2016 12:50:24 -0400
From:	Rhyland Klein <rklein@...dia.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	Laxman Dewangan <ldewangan@...dia.com>,
	<linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: max77620: Fix FPS switch statements

On 6/7/2016 4:05 AM, Lee Jones wrote:
> On Thu, 12 May 2016, Rhyland Klein wrote:
> 
>> When configuring FPS during probe, assuming a DT node is present for
>> FPS, the code can run into a problem with the switch statements in
>> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
>> in the case of chip->chip_id == MAX77620, it will set
>> fps_[mix|max]_period but then fall through to the default switch case
>> and return -EINVAL. Returning this from max77620_config_fps() will
>> cause probe to fail.
>>
>> Signed-off-by: Rhyland Klein <rklein@...dia.com>
>> ---
>>  drivers/mfd/max77620.c | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Applied to -fixes with Thierry and Laxman's Acks.
> 

I don't see this in linux-next yet (as of 20160614). Can we get this
merged there to.

-rhyland

-- 
nvpublic