linux-kernel - Re: [PATCH 2/5] export.h: use __is_defined() to check if __KSYM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1606141309560.1714@knanqh.ubzr>
Date:	Tue, 14 Jun 2016 13:10:47 -0400 (EDT)
From:	Nicolas Pitre <nicolas.pitre@...aro.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Michal Simek <michal.simek@...inx.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>, Michal Marek <mmarek@...e.cz>
Subject: Re: [PATCH 2/5] export.h: use __is_defined() to check if __KSYM_*
 is defined

On Tue, 14 Jun 2016, Masahiro Yamada wrote:

> Here the need is for a macro that checks whether the given symbol is
> defined or not, which has nothing to do with config.
> 
> The new macro __is_defined() is a better fit for this case.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Nicolas Pitre <nico@...aro.org>

> ---
> 
>  include/linux/export.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/export.h b/include/linux/export.h
> index 2f9ccbe..c565f87 100644
> --- a/include/linux/export.h
> +++ b/include/linux/export.h
> @@ -82,7 +82,7 @@ extern struct module __this_module;
>  #include <generated/autoksyms.h>
>  
>  #define __EXPORT_SYMBOL(sym, sec)				\
> -	__cond_export_sym(sym, sec, config_enabled(__KSYM_##sym))
> +	__cond_export_sym(sym, sec, __is_defined(__KSYM_##sym))
>  #define __cond_export_sym(sym, sec, conf)			\
>  	___cond_export_sym(sym, sec, conf)
>  #define ___cond_export_sym(sym, sec, enabled)			\
> -- 
> 1.9.1
> 
>