linux-kernel - Re: [PATCH] sched: Do not release current rq lock on non contended double_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614140228.0ecf15af@grimm.local.home>
Date:	Tue, 14 Jun 2016 14:02:28 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Clark Williams <williams@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Nick Piggin <nickpiggin@...oo.com.au>
Subject: Re: [PATCH] sched: Do not release current rq lock on non contended
 double_lock_balance()

On Tue, 14 Jun 2016 13:58:20 +0200
Peter Zijlstra <peterz@...radead.org> wrote:

> 
> The above puts a strict limit on hold time and is fair because of the
> queueing.
> 
> > +++ b/kernel/sched/sched.h
> > @@ -1548,10 +1548,15 @@ static inline int _double_lock_balance(struct rq *this_rq, struct rq *busiest)
> >  	__acquires(busiest->lock)
> >  	__acquires(this_rq->lock)
> >  {
> > +	int ret = 0;
> > +
> > +	if (unlikely(!raw_spin_trylock(&busiest->lock))) {
> > +		raw_spin_unlock(&this_rq->lock);
> > +		double_rq_lock(this_rq, busiest);
> > +		ret = 1;
> > +	}
> >  
> > +	return ret;
> >  }  
> 
> This relies on trylock no being allowed to steal the lock, which I think
> is true for all fair spinlocks (for ticket this must be true, but it is
> possible with qspinlock for example).
> 
> And it does indeed make the hold time harder to analyze.
> 
> For instance; pull_rt_task() does:
> 
> 	for_each_cpu() {
> 		double_lock_balance(this, that);
> 		...
> 		double_unlock_balance(this, that);
> 	}
> 
> Which, with the trylock, ends up with a max possible hold time of
> O(nr_cpus).

Sure, but I think we should try to limit that loop too, because that
loop itself is what is triggering the large latency for me, because
it constantly releases a spinlock and has to wait. This loop is done
with preemption disabled.

> 
> Unlikely, sure, but RT is a game of upper bounds etc.

Sure, but should we force worst case all the time?

We do a lot of optimization to allow for good throughput as well.

> 
> So should we maybe do something like:
> 
> 	if (unlikely(raw_spin_is_contended(&this_rq->lock) ||
> 	             !raw_spin_trylock(&busiest->lock))) {

Why do we care if this_rq is contended? That's exactly what causes
large latency to happen. Because when we let go of this_rq, this fast
path becomes much slower because now it must wait for whatever is
waiting on it to finish. The more CPUs you have, the bigger this issue
becomes.

If there's a loop on O(nr_cpus) (which is still technically O(1)) then
another CPU may need to wait for that loop to finish. But the loop
itself is kept tighter. If we always always release the lock, we allow
other CPUs to continue at the expense of the one CPU from continuing,
the K of that O(nr_cpus) becomes much larger and we consolidate the
latency all to a single CPU which may be the one that is running the
highest priority task in the system.

I'm seeing 100s us latency because of this. With this patch, that
latency disappears.

-- Steve

> 		raw_spin_unlock(&this_rq->lock);
> 		double_rq_lock(this_rq, busiest);
> 		ret = 1;
> 	}