linux-kernel - Re: [PATCH V5] irq: Track the interrupt timings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1606142010560.5839@nanos>
Date:	Tue, 14 Jun 2016 20:11:39 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Nicolas Pitre <nicolas.pitre@...aro.org>
cc:	Daniel Lezcano <daniel.lezcano@...aro.org>,
	shreyas@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
	peterz@...radead.org, rafael@...nel.org, vincent.guittot@...aro.org
Subject: Re: [PATCH V5] irq: Track the interrupt timings

On Tue, 14 Jun 2016, Nicolas Pitre wrote:
> What about simply this:
> 
> void __handle_timings(struct irq_desc *desc)
> {
> 	struct irq_timings *timings = this_cpu_ptr(desc->timings);
> 	timings->w_index = (timings->w_index + 1) & IRQ_TIMINGS_MASK;
> 	timings->values[timings->w_index] = local_clock();
> }
> 
> ?
> 
> Then you could s/__handle_timings/__record_irq_time/ to better represent 
> what it does.  And both the difference and the summing of squares could 
> be done upon entering idle instead.

And make it part of the handle_timings() inline to avoid the function call.

Thanks,

	tglx