linux-kernel - Re: [PATCH v2] backlight: lp855x: Add enable regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614200936.GA9318@rob-hp-laptop>
Date:	Tue, 14 Jun 2016 15:09:36 -0500
From:	Rob Herring <robh@...nel.org>
To:	Brian Norris <briannorris@...omium.org>
Cc:	Milo Kim <milo.kim@...com>, Jingoo Han <jingoohan1@...il.com>,
	Lee Jones <lee.jones@...aro.org>,
	Stephen Barber <smbarber@...omium.org>,
	Doug Anderson <dianders@...omium.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v2] backlight: lp855x: Add enable regulator

On Fri, Jun 10, 2016 at 12:39:57PM -0700, Brian Norris wrote:
> The LP8556 datasheet describes an EN/VDDIO input, which serves "both as
> a chip enable and as a power supply reference for PWM, SDA, and SCL
> inputs." The LP8556 that I'm testing doesn't respond properly if I try
> to talk I2C to it too quickly after enabling VDDIO, and the LP8555
> datasheet mentions a t_RESPONSE delay of up to 1 millisecond.
> 
> Support this EN/VDDIO by adding a regulator property to the binding;
> enabling this regulator at probe time; and sleeping for 1 to 2ms, if the
> EN/VDDIO regulator was provided.
> 
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
> v2: s/TS8555/LP8555/ in comment (typo)
> 
>  .../devicetree/bindings/leds/backlight/lp855x.txt  |  2 ++

I would have picked 'vddio' as the name, but it's fine.

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/video/backlight/lp855x_bl.c                | 29 ++++++++++++++++++++++
>  2 files changed, 31 insertions(+)