linux-kernel - Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k2hrbi31.fsf@ketchup.mtl.sfl>
Date:	Tue, 14 Jun 2016 17:01:38 -0400
From:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	netdev@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info

Hi,

Sergei Shtylyov <sergei.shtylyov@...entembedded.com> writes:

>> -	id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID);
>> +	of_id = of_match_node(mv88e6xxx_of_id_table, np);
>
>     You could use of_device_get_match_data() here.
>
>> +	if (!of_id)
>> +		return -EINVAL;
>> +
>> +	info = (const struct mv88e6xxx_info *)of_id->data;
>
>     Pointer casts from 'void *' are automatic.

I applied your comments and also squashed patches 7 and 8 together.
I'll respin a v3 soon unless there are other comments.

Thanks,

        Vivien