linux-kernel - Re: [PATCH v3 3/3] LSM: Add context interface for proc attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJY9c4YkniCg+Lm=CF9VUfFj9r=ND5_rtuhFG7nDGnCig@mail.gmail.com>
Date:	Tue, 14 Jun 2016 14:07:30 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Casey Schaufler <casey@...aufler-ca.com>
Cc:	LSM <linux-security-module@...r.kernel.org>,
	James Morris <jmorris@...ei.org>,
	John Johansen <john.johansen@...onical.com>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Paul Moore <paul@...l-moore.com>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	LKLM <linux-kernel@...r.kernel.org>,
	James Morris <james.l.morris@...cle.com>
Subject: Re: [PATCH v3 3/3] LSM: Add context interface for proc attr

On Tue, Jun 14, 2016 at 1:19 PM, Casey Schaufler <casey@...aufler-ca.com> wrote:
> On 6/14/2016 11:57 AM, Kees Cook wrote:

>> it's okay.) Also, should lsm == NULL be checked early and
>> rejected/skipped so the lsm != NULL test isn't needed in both loops?
>
> Ah, you miss the nuance of the code. NULL is an acceptance condition,
> not a rejection as it would be in most cases.

Ah! Yes, got it now. Thanks!

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security