linux-kernel - Re: [PATCH 1/1] selinuxfs: fix type mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhT1eRO64Fju5zuWRu0U4aaGPndNLMsOHRC4_Yg05NeBvA@mail.gmail.com>
Date:	Wed, 15 Jun 2016 16:25:18 -0400
From:	Paul Moore <paul@...l-moore.com>
To:	Heinrich Schuchardt <xypron.glpk@....de>
Cc:	Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, selinux@...ho.nsa.gov
Subject: Re: [PATCH 1/1] selinuxfs: fix type mismatch

On Fri, Jun 10, 2016 at 5:14 PM, Heinrich Schuchardt <xypron.glpk@....de> wrote:
> avc_cache_threshold is of type unsigned int.
>
> Do not use a signed new_value in
> sscanf(page, "%u", &new_value).
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
>  security/selinux/selinuxfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
> index 1b1fd27..0765c5b 100644
> --- a/security/selinux/selinuxfs.c
> +++ b/security/selinux/selinuxfs.c
> @@ -1347,7 +1347,7 @@ static ssize_t sel_write_avc_cache_threshold(struct file *file,
>  {
>         char *page;
>         ssize_t ret;
> -       int new_value;
> +       unsigned int new_value;
>
>         ret = task_has_security(current, SECURITY__SETSECPARAM);
>         if (ret)
> --
> 2.1.4
>



-- 
paul moore
www.paul-moore.com