linux-kernel - Re: [PATCH] staging:vt6656:card.c:Fix comment block issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5761BA18.9070500@osg.samsung.com>
Date:	Wed, 15 Jun 2016 21:27:04 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Rithvik Patibandla <rithvikp98@...il.com>,
	forest@...ttletooquiet.net
CC:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	habdul@...teon.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:vt6656:card.c:Fix comment block issue

On 11/06/16 21:08, Rithvik Patibandla wrote:
> Fix "Block comments use * on subsequent lines" and "Block comments use
> */ on trailing lines" warnings thrown by checkpatch.pl
> 
> Signed-off-by: Rithvik Patibandla <rithvikp98@...il.com>
> ---
>  drivers/staging/vt6656/card.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index a382fc6..607834c 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -47,7 +47,8 @@
>  #include "usbpipe.h"
>  
>  /* const u16 cwRXBCNTSFOff[MAX_RATE] =
> -   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */
> + *   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3};
> + */
>  
>  static const u16 cwRXBCNTSFOff[MAX_RATE] = {
>  	192, 96, 34, 17, 34, 23, 17, 11, 8, 5, 4, 3
> 

Hi Rithvik,

The following warning is indeed fixed :) This patch looks good.

WARNING: Block comments use * on subsequent lines
#50: FILE: drivers/staging/vt6656/card.c:50:
+/* const u16 cwRXBCNTSFOff[MAX_RATE] =
+   {17, 34, 96, 192, 34, 23, 17, 11, 8, 5, 4, 3}; */


There are 32 other checks that checkpatch complains about in that file.
Please send fixes for those as well.

Luis