linux-kernel - Re: [PATCH v9 3/4] Add Cyclomatic complexity GCC plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160615225331.abb990e0302757ea9a6a3500@gmail.com>
Date:	Wed, 15 Jun 2016 22:53:31 +0200
From:	Emese Revfy <re.emese@...il.com>
To:	Laura Abbott <labbott@...hat.com>
Cc:	linux-kbuild@...r.kernel.org, pageexec@...email.hu,
	spender@...ecurity.net, kernel-hardening@...ts.openwall.com,
	mmarek@...e.com, keescook@...omium.org, linux@...musvillemoes.dk,
	fengguang.wu@...el.com, dvyukov@...gle.com,
	linux-kernel@...r.kernel.org, david.brown@...aro.org,
	yamada.masahiro@...ionext.com, minipli@...linux.so
Subject: Re: [PATCH v9 3/4] Add Cyclomatic complexity GCC plugin

On Tue, 14 Jun 2016 12:29:59 -0700
Laura Abbott <labbott@...hat.com> wrote:

> On 05/23/2016 03:10 PM, Emese Revfy wrote:
> 1) make mrproper
> 2) make defconfig
> 3) enable GCC_PLUGINS, GCC_PLUGIN_CYC_COMPLEXITY
> 4) enable FUNCTION_TRACER (it will select other options as well)
> 5) make && make modules
> 
> ERROR: "__fentry__" [net/ipv4/netfilter/ipt_MASQUERADE.ko] undefined!
> ERROR: "__fentry__" [fs/efivarfs/efivarfs.ko] undefined!
> ERROR: "__fentry__" [drivers/thermal/x86_pkg_temp_thermal.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1

The patch below fixes this bug, but I think it is ugly.
https://github.com/ephox-gcc-plugins/gcc-plugins_linux-next/commit/73e2d117daa7f3c6aee8935ecbb318354ff9cd82

If anyone has a better idea to fix this, please let me know.

Thanks
-- 
Emese