linux-kernel - Re: [PATCH v3 7/8] acpi: add support for configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0ip=GuF041dR3m4mMSOqxMU7BDMYC2YTpKtCsjL6pXM+w@mail.gmail.com>
Date:	Wed, 15 Jun 2016 23:02:20 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Octavian Purdila <octavian.purdila@...el.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	kbuild test robot <lkp@...el.com>, kbuild-all@...org,
	Len Brown <lenb@...nel.org>,
	Matt Fleming <matt@...eblueprint.co.uk>,
	Mark Brown <broonie@...nel.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Joel Becker <jlbec@...lplan.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	linux-efi@...r.kernel.org, linux-i2c <linux-i2c@...r.kernel.org>,
	linux-spi <linux-spi@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Irina Tirdea <irina.tirdea@...el.com>
Subject: Re: [PATCH v3 7/8] acpi: add support for configfs

On Wed, Jun 15, 2016 at 12:20 PM, Octavian Purdila
<octavian.purdila@...el.com> wrote:
> On Wed, Jun 15, 2016 at 1:59 AM, Rafael J. Wysocki <rjw@...ysocki.net> wrote:
>> Hi Octavian,
>>
>> On Wednesday, June 15, 2016 06:43:21 AM kbuild test robot wrote:
>>> Hi,
>>>
>>> [auto build test ERROR on pm/linux-next]
>>> [also build test ERROR on v4.7-rc3]
>>> [cannot apply to next-20160614]
>>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>>
>>> url:    https://github.com/0day-ci/linux/commits/Octavian-Purdila/ACPI-overlays/20160614-202312
>>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
>>> config: x86_64-allyesconfig (attached as .config)
>>> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
>>> reproduce:
>>>         # save the attached .config to linux build tree
>>>         make ARCH=x86_64
>>>
>>> Note: the linux-review/Octavian-Purdila/ACPI-overlays/20160614-202312 HEAD 042f716a165ffa274684c787377acddfc1f34e3f builds fine.
>>>       It only hurts bisectibility.
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>    drivers/acpi/configfs.c: In function 'acpi_configfs_init':
>>> >> drivers/acpi/configfs.c:19:31: error: 'acpi_configfs' undeclared (first use in this function)
>>>      struct config_group *root = &acpi_configfs.su_group;
>>>                                   ^~~~~~~~~~~~~
>>>    drivers/acpi/configfs.c:19:31: note: each undeclared identifier is reported only once for each function it appears in
>>>    drivers/acpi/configfs.c: In function 'acpi_configfs_exit':
>>>    drivers/acpi/configfs.c:33:33: error: 'acpi_configfs' undeclared (first use in this function)
>>>      configfs_unregister_subsystem(&acpi_configfs);
>>>                                     ^~~~~~~~~~~~~
>>>
>>> vim +/acpi_configfs +19 drivers/acpi/configfs.c
>>>
>>>     13        #include <linux/configfs.h>
>>>     14        #include <linux/acpi.h>
>>>     15
>>>     16        static int __init acpi_configfs_init(void)
>>>     17        {
>>>     18                int ret;
>>>   > 19                struct config_group *root = &acpi_configfs.su_group;
>>>     20
>>>     21                config_group_init(root);
>>>     22
>>>
>>> ---
>>
>> Any chance to send an updated patch with this fixed?
>>
>> No need to resend the whole series, just this single patch, please.
>>
>
> Oops, sorry about that. I will have to resend at least the last two
> patches to fix this issue, but since I have missed to add the
> Reviewed-by from Mika for another two patches, its probably best to
> resend the whole series?

Yes, please.