linux-kernel - Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5760B604.10407@samsung.com>
Date:	Wed, 15 Jun 2016 10:57:24 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	Roger Quadros <rogerq@...com>, myungjoo.ham@...sung.com
Cc:	balbi@...nel.org, nm@...com, grygorii.strashko@...com,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] extcon: palmas: Fix boot up state of VBUS when using GPIO
 detection

On 2016년 06월 14일 23:04, Roger Quadros wrote:
> If USB cable is connected prior to boot, we don't get any interrupts
> so we must manually check the VBUS state and report it during probe.
> If we don't do it then USB controller will never know that peripheral
> cable was connected till the user unplugs and replugs the cable.
> 
> Fixes: b7aad8e2685b ("extcon: palmas: Add the support for VBUS detection by using GPIO")
> Signed-off-by: Roger Quadros <rogerq@...com>
> ---
>  drivers/extcon/extcon-palmas.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 8b3226d..caff46c 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -360,6 +360,8 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  
>  	palmas_enable_irq(palmas_usb);
>  	/* perform initial detection */
> +	if (palmas_usb->enable_gpio_vbus_detection)
> +		palmas_vbus_irq_handler(palmas_usb->gpio_vbus_irq, palmas_usb);
>  	palmas_gpio_id_detect(&palmas_usb->wq_detectid.work);
>  	device_set_wakeup_capable(&pdev->dev, true);
>  	return 0;
> 

Applied it.

Thanks,
Chanwoo Choi