linux-kernel - Re: [PATCH] ALSA: seq_oss: Change structure initialisation to C99 style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5heg7yoom0.wl-tiwai@suse.de>
Date:	Wed, 15 Jun 2016 10:14:31 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Amitoj Kaur Chawla" <amitoj1606@...il.com>
Cc:	<alsa-devel@...a-project.org>, <perex@...ex.cz>,
	<linux-kernel@...r.kernel.org>, <keescook@...omium.org>,
	<michael.leibowitz@...el.com>, <julia.lawall@...6.fr>
Subject: Re: [PATCH] ALSA: seq_oss: Change structure initialisation to C99 style

On Wed, 15 Jun 2016 10:03:31 +0200,
Amitoj Kaur Chawla wrote:
> 
> Replace the in order struct initialisation style with explicit field
> style.
> 
> The Coccinelle semantic patch used to make this change is as follows:
> 
> @decl@
> identifier i1,fld;
> type T;
> field list[n] fs;
> @@
> 
> struct i1 {
>  fs
>  T fld;
>  ...};
> 
> @@
> identifier decl.i1,i2,decl.fld;
> expression e;
> position bad.p, bad.fix;
> @@
> 
> struct i1 i2@p = { ...,
> + .fld = e
> - e@fix
>  ,...};
> 
> Also, removed some unnecessary comments.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>

Applied, thanks.


Takashi