linux-kernel - Re: [PATCH v3] storvsc: use small sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1fusfb3y1.fsf@sermon.lab.mkp.net>
Date:	Tue, 14 Jun 2016 22:07:02 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Olaf Hering <olaf@...fle.de>
Cc:	James Bottomley <jejb@...ux.vnet.ibm.com>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH v3] storvsc: use small sg_tablesize on x86

>>>>> "Olaf" == Olaf Hering <olaf@...fle.de> writes:

Olaf> On Thu, Jun 09, James Bottomley wrote:
>> On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote:
>> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, >
>> after > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi:
>> storvsc: Set > the > tablesize based on the information given by the
>> host")
>> > 
>> > [ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> >
>> 0x20
>> 
>> Are you really sure 32 is the correct size?

Olaf> Its a size that works, while the current state does not work at
Olaf> all.

>> I know 32 it what it had before, but the reason for the commit you
>> quote was to improve performance ...

Olaf> The commit above broke 32bit. Whoever wants to improve performance
Olaf> on this dead horse can submit another patch.

K.Y.?

-- 
Martin K. Petersen	Oracle Linux Engineering