linux-kernel - Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1465982230.30123.106.camel@linux.intel.com>
Date:	Wed, 15 Jun 2016 12:17:10 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Dan O'Donovan <dan@...tex.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on
 Edison

On Wed, 2016-06-15 at 10:06 +0200, Ingo Molnar wrote:
> * Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > +static const struct devs_id pcal9555a_1_dev_id __initconst = {
> > +	.name = "pcal9555a-1",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_2_dev_id __initconst = {
> > +	.name = "pcal9555a-2",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_3_dev_id __initconst = {
> > +	.name = "pcal9555a-3",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> > +
> > +static const struct devs_id pcal9555a_4_dev_id __initconst = {
> > +	.name = "pcal9555a-4",
> > +	.type = SFI_DEV_TYPE_I2C,
> > +	.delay = 1,
> > +	.get_platform_data = &pcal9555a_platform_data,
> > +};
> 
> I have the same complaint as yesterday. Going forward could we please
> get nice 
> structure initializers in all future patches? :)

Oops, indeed. Sorry, will send new version soon.

-- 

Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy