[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20160615092426.GS24234@mail.corp.redhat.com>
Date: Wed, 15 Jun 2016 11:24:26 +0200
From: Benjamin Tissoires <benjamin.tissoires@...hat.com>
To: Andrew Duggan <aduggan@...aptics.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Linus Walleij <linus.walleij@...aro.org>,
Jiri Kosina <jikos@...nel.org>,
Vincent Huang <vincent.huang@...synaptics.com>,
Nick Dyer <nick.dyer@...ev.co.uk>
Subject: Re: [PATCH 1/7] Input: synaptics-rmi4: Increment the refcount of the
transport dev's of_node
On Jun 03 2016 or thereabouts, Andrew Duggan wrote:
> Increment the refcount for the transport device's of_node before calling
> of_find_node_by_name(). Since of_find_node_by_name() assumes the refcount
> was incremented by the caller and calls of_node_put() when it is done.
That is some weird API. I guess it must be used with:
of_node = of_find_node_by_name(of_node, of_name);
Anyway:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cheers,
Benjamin
>
> Signed-off-by: Andrew Duggan <aduggan@...aptics.com>
> ---
> drivers/input/rmi4/rmi_bus.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c
> index b368b05..55b5336 100644
> --- a/drivers/input/rmi4/rmi_bus.c
> +++ b/drivers/input/rmi4/rmi_bus.c
> @@ -157,11 +157,12 @@ static int rmi_function_match(struct device *dev, struct device_driver *drv)
> static void rmi_function_of_probe(struct rmi_function *fn)
> {
> char of_name[9];
> + struct device_node *node = fn->rmi_dev->xport->dev->of_node;
>
> snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
> fn->fd.function_number);
> - fn->dev.of_node = of_find_node_by_name(
> - fn->rmi_dev->xport->dev->of_node, of_name);
> + of_node_get(node);
> + fn->dev.of_node = of_find_node_by_name(node, of_name);
> }
> #else
> static inline void rmi_function_of_probe(struct rmi_function *fn)
> --
> 2.5.0
>
Powered by blists - more mailing lists