| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jun 2016 17:49:39 +0800
From: kbuild test robot <lkp@...el.com>
To: Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
Cc: kbuild-all@...org, linux-kernel@...r.kernel.org,
linux-arch@...r.kernel.org, ingo@...hat.com, peterz@...radead.org,
arnd@...db.de, Waiman.Long@....com, will.deacon@....com,
Pan Xinhui <xinhui.pan@...ux.vnet.ibm.com>
Subject: Re: [PATCH] locking/qrwlock: Let qrwlock has same layout regardless
of the endian
Hi,
[auto build test WARNING on asm-generic/master]
[also build test WARNING on v4.7-rc3 next-20160615]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Pan-Xinhui/locking-qrwlock-Let-qrwlock-has-same-layout-regardless-of-the-endian/20160615-172044
base: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic master
config: x86_64-randconfig-x016-201624 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from arch/x86/include/asm/qrwlock.h:5:0,
from arch/x86/include/asm/spinlock.h:219,
from include/linux/spinlock.h:87,
from include/linux/mmzone.h:7,
from include/linux/gfp.h:5,
from include/linux/slab.h:14,
from include/linux/crypto.h:24,
from arch/x86/kernel/asm-offsets.c:8:
include/asm-generic/qrwlock.h: In function 'queued_read_can_lock':
include/asm-generic/qrwlock.h:40:29: error: '_QW_SHIFT' undeclared (first use in this function)
#define _QW_WMASK (0xffU << _QW_SHIFT) /* Writer mask */
^
include/asm-generic/qrwlock.h:55:38: note: in expansion of macro '_QW_WMASK'
return !(atomic_read(&lock->cnts) & _QW_WMASK);
^~~~~~~~~
include/asm-generic/qrwlock.h:40:29: note: each undeclared identifier is reported only once for each function it appears in
#define _QW_WMASK (0xffU << _QW_SHIFT) /* Writer mask */
^
include/asm-generic/qrwlock.h:55:38: note: in expansion of macro '_QW_WMASK'
return !(atomic_read(&lock->cnts) & _QW_WMASK);
^~~~~~~~~
In file included from arch/x86/include/asm/atomic.h:4:0,
from include/linux/atomic.h:4,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:8:
include/asm-generic/qrwlock.h: In function 'queued_read_trylock':
include/asm-generic/qrwlock.h:40:29: error: '_QW_SHIFT' undeclared (first use in this function)
#define _QW_WMASK (0xffU << _QW_SHIFT) /* Writer mask */
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> include/asm-generic/qrwlock.h:77:2: note: in expansion of macro 'if'
if (likely(!(cnts & _QW_WMASK))) {
^~
>> include/asm-generic/qrwlock.h:77:6: note: in expansion of macro 'likely'
if (likely(!(cnts & _QW_WMASK))) {
^~~~~~
include/asm-generic/qrwlock.h:77:22: note: in expansion of macro '_QW_WMASK'
if (likely(!(cnts & _QW_WMASK))) {
^~~~~~~~~
include/asm-generic/qrwlock.h: In function 'queued_write_trylock':
include/asm-generic/qrwlock.h:39:30: error: '_QW_SHIFT' undeclared (first use in this function)
#define _QW_LOCKED (0xffU << _QW_SHIFT) /* A writer holds the lock */
^
include/linux/compiler.h:138:43: note: in definition of macro 'likely'
# define likely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 1))
^
include/asm-generic/qrwlock.h:100:24: note: in expansion of macro '_QW_LOCKED'
cnts, cnts | _QW_LOCKED) == cnts);
^~~~~~~~~~
include/asm-generic/qrwlock.h: In function 'queued_read_lock':
include/asm-generic/qrwlock.h:40:29: error: '_QW_SHIFT' undeclared (first use in this function)
#define _QW_WMASK (0xffU << _QW_SHIFT) /* Writer mask */
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
include/asm-generic/qrwlock.h:111:2: note: in expansion of macro 'if'
if (likely(!(cnts & _QW_WMASK)))
^~
include/asm-generic/qrwlock.h:111:6: note: in expansion of macro 'likely'
if (likely(!(cnts & _QW_WMASK)))
^~~~~~
include/asm-generic/qrwlock.h:111:22: note: in expansion of macro '_QW_WMASK'
if (likely(!(cnts & _QW_WMASK)))
^~~~~~~~~
include/asm-generic/qrwlock.h: In function 'queued_write_lock':
include/asm-generic/qrwlock.h:39:30: error: '_QW_SHIFT' undeclared (first use in this function)
#define _QW_LOCKED (0xffU << _QW_SHIFT) /* A writer holds the lock */
^
include/linux/compiler.h:151:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
include/asm-generic/qrwlock.h:125:2: note: in expansion of macro 'if'
if (atomic_cmpxchg_acquire(&lock->cnts, 0, _QW_LOCKED) == 0)
^~
include/asm-generic/qrwlock.h:125:45: note: in expansion of macro '_QW_LOCKED'
if (atomic_cmpxchg_acquire(&lock->cnts, 0, _QW_LOCKED) == 0)
^~~~~~~~~~
make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [sub-make] Error 2
vim +/if +77 include/asm-generic/qrwlock.h
c85626c3 Pan Xinhui 2016-06-15 34 #define _QR_SHIFT 0 /* Reader count shift */
c85626c3 Pan Xinhui 2016-06-15 35 #define _QW_SHIFT 24 /* Writer mode shift */
c85626c3 Pan Xinhui 2016-06-15 36 #endif
c85626c3 Pan Xinhui 2016-06-15 37
c85626c3 Pan Xinhui 2016-06-15 38 #define _QW_WAITING (1U << _QW_SHIFT) /* A writer is waiting */
c85626c3 Pan Xinhui 2016-06-15 39 #define _QW_LOCKED (0xffU << _QW_SHIFT) /* A writer holds the lock */
c85626c3 Pan Xinhui 2016-06-15 @40 #define _QW_WMASK (0xffU << _QW_SHIFT) /* Writer mask */
70af2f8a Waiman Long 2014-02-03 41 #define _QR_BIAS (1U << _QR_SHIFT)
70af2f8a Waiman Long 2014-02-03 42
70af2f8a Waiman Long 2014-02-03 43 /*
70af2f8a Waiman Long 2014-02-03 44 * External function declarations
70af2f8a Waiman Long 2014-02-03 45 */
0e06e5be Waiman Long 2015-06-19 46 extern void queued_read_lock_slowpath(struct qrwlock *lock, u32 cnts);
f7d71f20 Waiman Long 2015-06-19 47 extern void queued_write_lock_slowpath(struct qrwlock *lock);
70af2f8a Waiman Long 2014-02-03 48
70af2f8a Waiman Long 2014-02-03 49 /**
f7d71f20 Waiman Long 2015-06-19 50 * queued_read_can_lock- would read_trylock() succeed?
70af2f8a Waiman Long 2014-02-03 51 * @lock: Pointer to queue rwlock structure
70af2f8a Waiman Long 2014-02-03 52 */
f7d71f20 Waiman Long 2015-06-19 53 static inline int queued_read_can_lock(struct qrwlock *lock)
70af2f8a Waiman Long 2014-02-03 54 {
70af2f8a Waiman Long 2014-02-03 55 return !(atomic_read(&lock->cnts) & _QW_WMASK);
70af2f8a Waiman Long 2014-02-03 56 }
70af2f8a Waiman Long 2014-02-03 57
70af2f8a Waiman Long 2014-02-03 58 /**
f7d71f20 Waiman Long 2015-06-19 59 * queued_write_can_lock- would write_trylock() succeed?
70af2f8a Waiman Long 2014-02-03 60 * @lock: Pointer to queue rwlock structure
70af2f8a Waiman Long 2014-02-03 61 */
f7d71f20 Waiman Long 2015-06-19 62 static inline int queued_write_can_lock(struct qrwlock *lock)
70af2f8a Waiman Long 2014-02-03 63 {
70af2f8a Waiman Long 2014-02-03 64 return !atomic_read(&lock->cnts);
70af2f8a Waiman Long 2014-02-03 65 }
70af2f8a Waiman Long 2014-02-03 66
70af2f8a Waiman Long 2014-02-03 67 /**
f7d71f20 Waiman Long 2015-06-19 68 * queued_read_trylock - try to acquire read lock of a queue rwlock
70af2f8a Waiman Long 2014-02-03 69 * @lock : Pointer to queue rwlock structure
70af2f8a Waiman Long 2014-02-03 70 * Return: 1 if lock acquired, 0 if failed
70af2f8a Waiman Long 2014-02-03 71 */
f7d71f20 Waiman Long 2015-06-19 72 static inline int queued_read_trylock(struct qrwlock *lock)
70af2f8a Waiman Long 2014-02-03 73 {
70af2f8a Waiman Long 2014-02-03 74 u32 cnts;
70af2f8a Waiman Long 2014-02-03 75
70af2f8a Waiman Long 2014-02-03 76 cnts = atomic_read(&lock->cnts);
70af2f8a Waiman Long 2014-02-03 @77 if (likely(!(cnts & _QW_WMASK))) {
77e430e3 Will Deacon 2015-08-06 78 cnts = (u32)atomic_add_return_acquire(_QR_BIAS, &lock->cnts);
70af2f8a Waiman Long 2014-02-03 79 if (likely(!(cnts & _QW_WMASK)))
70af2f8a Waiman Long 2014-02-03 80 return 1;
:::::: The code at line 77 was first introduced by commit
:::::: 70af2f8a4f48d6cebdf92d533d3aef37853ce6de locking/rwlocks: Introduce 'qrwlocks' - fair, queued rwlocks
:::::: TO: Waiman Long <Waiman.Long@...com>
:::::: CC: Ingo Molnar <mingo@...nel.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/octet-stream" (22480 bytes)
Powered by blists - more mailing lists