linux-kernel - Re: [PATCH V2] block: correctly fallback for zeroout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1bn33b3l1.fsf@sermon.lab.mkp.net>
Date:	Tue, 14 Jun 2016 22:14:50 -0400
From:	"Martin K. Petersen" <martin.petersen@...cle.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Shaohua Li <shli@...com>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, axboe@...com, sitsofe@...oo.com,
	snitzer@...hat.com, Kernel-team@...com
Subject: Re: [PATCH V2] block: correctly fallback for zeroout

>>>>> "Christoph" == Christoph Hellwig <hch@...radead.org> writes:

Christoph> We can move the sanity checks out.  Or even better get rid of
Christoph> the stupid behavior of ignoring the late -EOPNOTSUPP in this
Christoph> low level helper and instead leaving it to the caller(s) that
Christoph> care.

It definitely should be a caller decision whether to ignore the return
value or not.

>> I am OK with your patch as a stable fix but this really needs to be
>> fixed up properly.

Christoph> And I'd much prefer to get this right now.  It's not like
Christoph> this is recently introduced behavior.

Unfortunately there are quite a few callers of blkdev_issue_discard()
these days. Some of them ignore the return value but not all of
them. I'm concerned about causing all sorts of breakage if we suddenly
start returning errors various places in the stable trees.

-- 
Martin K. Petersen	Oracle Linux Engineering