linux-kernel - Re: [PATCH 2/2] iommu/amd: Destroy api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160615115406.GF26566@8bytes.org>
Date:	Wed, 15 Jun 2016 13:54:07 +0200
From:	"joro@...tes.org" <joro@...tes.org>
To:	"Vesely, Jan" <Jan.Vesely@....com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>
Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

On Thu, Jun 09, 2016 at 03:48:44PM +0000, Vesely, Jan wrote:
> On Sat, 2016-05-21 at 14:11 -0400, Jan Vesely wrote:
> > From: Jan Vesely <jan.vesely@....com>
> > 
> > Signed-off-by: Jan Vesely <jan.vesely@....com>
> > ---
> >  drivers/iommu/amd_iommu.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> > index 17c76f2..4ff5e40 100644
> > --- a/drivers/iommu/amd_iommu.c
> > +++ b/drivers/iommu/amd_iommu.c
> > @@ -3016,6 +3016,7 @@ static void protection_domain_free(struct
> > protection_domain *domain)
> >  
> >  	del_domain_from_list(domain);
> >  
> > +	mutex_destroy(&domain->api_lock);
> >  	if (domain->id)
> >  		domain_id_free(domain->id);
> >  
> 
> ping

Your patches lack commit messages, please add a more detailed
description of what you are fixing and why. Please also add 'Fixes:'
tags when resubmitting. The changes itself look good to me.


	Joerg