lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 15 Jun 2016 14:48:42 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	"Andrew F. Davis" <afd@...com>
Cc:	kbuild test robot <lkp@...el.com>, kbuild-all@...org,
	Russell King <linux@...linux.org.uk>,
	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Richard Purdie <rpurdie@...ys.net>,
	Jacek Anaszewski <j.anaszewski@...sung.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
	Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Ingo Molnar <mingo@...nel.org>, linux-pwm@...r.kernel.org,
	lguest@...ts.ozlabs.org, linux-wireless@...r.kernel.org,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, linux-leds@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled

Hi Andrew,

On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote:
> If the HSI core is built as a module hsi_boardinfo may still
> be built-in as its Kconfig type is bool, which can cause build
> issues. Fix this by building this code into the HSI core when
> enabled.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Andrew F. Davis <afd@...com>
> ---
> This build error seems to be due to Kconfig symbol CONFIG_HSI_BOARDINFO
> being a bool but depending on a tristate (CONFIG_HSI). This is normally
> okay when it is just a flag to enable a feature in source, but the
> helper code file hsi_boardinfo.c is built as a separate entity when
> enabled. This patch is probably how it was intended, and is more like
> how others do this kind of thing.
> 
> This patch should be applied before the parent patch:

Thanks, I applied both patches.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)

Powered by blists - more mailing lists