lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Jun 2016 21:17:49 +0800 From: Chen-Yu Tsai <wens@...e.org> To: Lee Jones <lee.jones@...aro.org> Cc: Chen-Yu Tsai <wens@...e.org>, Mark Brown <broonie@...nel.org>, Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...e-electrons.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Maxime Ripard <maxime.ripard@...e-electrons.com>, Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...eaurora.org>, rtc-linux@...glegroups.com, linux-kernel <linux-kernel@...r.kernel.org>, devicetree <devicetree@...r.kernel.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, linux-clk <linux-clk@...r.kernel.org> Subject: Re: [PATCH v2 02/10] mfd: ac100: Add device tree bindings for X-Powers AC100 codec/RTC combo IC On Wed, Jun 15, 2016 at 8:49 PM, Lee Jones <lee.jones@...aro.org> wrote: > On Wed, 15 Jun 2016, Chen-Yu Tsai wrote: > >> Signed-off-by: Chen-Yu Tsai <wens@...e.org> >> --- >> Documentation/devicetree/bindings/mfd/ac100.txt | 42 +++++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/ac100.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/ac100.txt b/Documentation/devicetree/bindings/mfd/ac100.txt >> new file mode 100644 >> index 000000000000..fbab623e6fba >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/ac100.txt >> @@ -0,0 +1,42 @@ >> +X-Powers AC100 Codec/RTC IC device tree bindings >> + >> +AC100 is a audio codec and RTC subsystem combo IC. The 2 parts are >> +separated, including power supplies and interrupt lines, but share >> +a common register address space and host interface. >> + >> +Required properties: >> +- compatible: "x-powers,ac100" >> +- reg: The I2C slave address or RSB hardware address for the chip >> +- sub-nodes: >> + - codec >> + - compatible: "x-powers,ac100-codec" >> + - interrupt-parent: The parent interrupt controller >> + - interrupts: SoC NMI / GPIO interrupt connected to the IRQ_AUDIO pin >> + - rtc >> + - compatible: "x-powers,ac100-rtc" >> + - interrupt-parent: The parent interrupt controller >> + - interrupts: SoC NMI / GPIO interrupt connected to the IRQ_RTC pin >> + - #clock-cells: shall be 1 >> + - clock-output-names: "cko1_rtc", "cko2_rtc", "cko3_rtc" >> + - see clock/clock-bindings.txt for common clock bindings >> + >> +Example: >> + >> +ac100: codec@e89 { >> + compatible = "x-powers,ac100"; >> + reg = <0xe89>; >> + >> + ac100_codec { >> + compatible = "x-powers,ac100-codec"; >> + interrupt-parent = <&nmi_intc>; >> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; >> + }; >> + >> + ac100_rtc { >> + compatible = "x-powers,ac100-rtc"; >> + interrupt-parent = <&nmi_intc>; >> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > Isn't this the same interrupt as above? Is it shared? Copy paste error... The codec uses a different line in the design. ChenYu > >> + #clock-cells = <1>; >> + clock-output-names = "cko1_rtc", "cko2_rtc", "cko3_rtc"; >> + }; >> +}; > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists