linux-kernel - Re: [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Jun 2016 15:29:49 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	"Amitoj Kaur Chawla" <amitoj1606@...il.com>
Cc:	<alsa-devel@...a-project.org>, <perex@...ex.cz>,
	<linux-kernel@...r.kernel.org>, <keescook@...omium.org>,
	<michael.leibowitz@...el.com>, <julia.lawall@...6.fr>
Subject: Re: [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style

On Wed, 15 Jun 2016 15:26:34 +0200,
Amitoj Kaur Chawla wrote:
> 
> Replace the in order struct initialisation style with explicit field
> style.
> 
> The Coccinelle semantic patch used to make this change is as follows:
> 
> @decl@
> identifier i1,fld;
> type T;
> field list[n] fs;
> @@
> 
> struct i1 {
>  fs
>  T fld;
>  ...};
> 
> @@
> identifier decl.i1,i2,decl.fld;
> expression e;
> position bad.p, bad.fix;
> @@
> 
> struct i1 i2@p = { ...,
> + .fld = e
> - e@fix
>  ,...};
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>  sound/usb/mixer_maps.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
> index 1f8fb0d9..9038b2e 100644
> --- a/sound/usb/mixer_maps.c
> +++ b/sound/usb/mixer_maps.c
> @@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = {
>   * e.g. no Master and fake PCM volume
>   *			Pavel Mihaylov <bin@...h.info>
>   */
> -static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0};	/* just guess */
> -static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */
> +static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0};
> +						/* just guess */
> +static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618};
> +						/* just guess */

These are simple min/max table, so no big merit to write in such a
way.


thanks,

Takashi