linux-kernel - Re: select on non-existing Kconfig option CRC32C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160615144153.GB4700@linux.vnet.ibm.com>
Date:	Wed, 15 Jun 2016 16:41:53 +0200
From:	Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>
To:	Andreas Ziegler <andreas.ziegler@....de>
Cc:	Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	linux-crypto@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: select on non-existing Kconfig option CRC32C

Hi Andreas,

On Wed, Jun 15, 2016 at 12:00:59PM +0200, Andreas Ziegler wrote:
> 
> your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
> algorithms" showed up in linux-next today (next-20160615) as commit 	364148e0b195.
> 
> The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C.
> However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist.

Thanks for informing me.  Actually, the crc32-vx driver requires the
__crc32c_le() function which is available by selecting CONFIG_CRC32. There is
no need for CRYPTO_CRC32C.  So this can be safely removed.

> Should I prepare a trivial patch to fix this up or would you like to do that on
> your side?

Martin have already corrected the patch.

Thanks and kind regards,
  Hendrik