linux-kernel - Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it to the install list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5761B676.70603@osg.samsung.com>
Date:	Wed, 15 Jun 2016 14:11:34 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Yannick Brosseau <scientist@...com>,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	kernel-team@...com, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests/exec: Makefile is a run-time dependency, add it
 to the install list

On 06/15/2016 12:36 PM, Yannick Brosseau wrote:
> The execveat test try to exec the Makefile file and expect an EACCES results. When running
> the test in the installed destination it would fail with ENOENT since the file is
> not there.
> Add Makefile to the TEST_FILES list so it's copied at install time.
> 
> Signed-off-by: Yannick Brosseau <scientist@...com>
> ---
>  tools/testing/selftests/exec/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
> index 4e400eb..d430060 100644
> --- a/tools/testing/selftests/exec/Makefile
> +++ b/tools/testing/selftests/exec/Makefile
> @@ -18,7 +18,8 @@ execveat.denatured: execveat
>  	$(CC) $(CFLAGS) -o $@ $^
>  
>  TEST_PROGS := execveat
> -TEST_FILES := $(DEPS)
> +# Makefile is a run-time dependency, since it's accessed by the execveat test
> +TEST_FILES := $(DEPS) Makefile
>  
>  include ../lib.mk
>  
> 

Thanks. Applied and queued for the next rc in linux-kselftest fixes branch

-- Shuah