linux-kernel - Re: [PATCH] libnvdimm: use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160616073418.h27grfty4f4jrii5@c203.arch.suse.de>
Date:	Thu, 16 Jun 2016 09:34:18 +0200
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	linux-nvdimm@...ts.01.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libnvdimm: use devm_add_action_or_reset()

On Wed, Jun 15, 2016 at 04:31:55PM -0700, Dan Williams wrote:
> Clean up needless calls to the action routine by letting
> devm_add_action_or_reset() call it automatically.  This does cause the
> disk to registered and immediately unregistered when a memory allocation
> fails, but the block layer should be prepared for such an event.
> 
> Reported-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@...e.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850