linux-kernel - RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU Boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2E89032DDAA8B9408CB92943514A0337D4643174@SW-EX-MBX01.diasemi.com>
Date:	Thu, 16 Jun 2016 08:40:45 +0000
From:	"Opensource [Adam Thomson]" <Adam.Thomson.Opensource@...semi.com>
To:	Xing Zheng <zhengxing@...k-chips.com>,
	Steve Barber <smbarber@...gle.com>
CC:	"linux-rockchip@...ts.infradead.org" 
	<linux-rockchip@...ts.infradead.org>,
	Mark Rutland <mark.rutland@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
	Douglas Anderson <dianders@...omium.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Heiko Stübner <heiko@...ech.de>
Subject: RE: [PATCH v5] ASoC: rockchip: Add machine driver for RK3399 GRU
 Boards

On 16 June 2016 02:15, Xing Zheng wrote:

> >> +       /* Enable Headset and 4 Buttons Jack detection */
> >> +       ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
> >> +                                   SND_JACK_HEADSET |
> > Should this also include SND_JACK_LINEOUT? da7219 differentiates
> > between the two so not including lineout means, for example, we can
> > miss jack insertion/removal events.
> >
> Hi Adam,
> 
> Could you please confirm Steve says that about SND_JACK_LINEOUT?
> 
> Thanks.

Hi Xing Zheng,

Yes, as Steve mentioned DA7219 does support SND_JACK_LINEOUT so we should really
include this here.