linux-kernel - Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1466074010.3343.15.camel@pengutronix.de>
Date:	Thu, 16 Jun 2016 12:46:50 +0200
From:	Philipp Zabel <p.zabel@...gutronix.de>
To:	Xinliang Liu <xinliang.liu@...aro.org>
Cc:	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	xuwei5@...ilicon.com, puck.chen@...ilicon.com,
	saberlily.xia@...ilicon.com, kong.kongxinwei@...ilicon.com,
	guodong.xu@...aro.org
Subject: Re: [PATCH v2 1/3] reset: hisilicon: Add media reset controller
 binding

Am Donnerstag, den 16.06.2016, 18:29 +0800 schrieb Xinliang Liu:
> Add compatible for media reset controller.
> 
> Signed-off-by: Xinliang Liu <xinliang.liu@...aro.org>
> ---
>  Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> index e0b185a944ba..c25da39df707 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi6220-reset.txt
> @@ -8,7 +8,9 @@ The reset controller registers are part of the system-ctl block on
>  hi6220 SoC.
>  
>  Required properties:
> -- compatible: may be "hisilicon,hi6220-sysctrl"
> +- compatible: should be one of the following:
> +  - "hisilicon,hi6220-sysctrl", "syscon" : For peripheral reset controller.
> +  - "hisilicon,hi6220-mediactrl", "syscon" : For media reset controller.

This does more than the commit message says. Why do you add syscon here?
Do the sysctrl and mediactrl register ranges have bits other than reset
controls that will be used by other drivers via the syscon mechanism?

regards
Philipp