linux-kernel - Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <57629AB9.2090506@samsung.com>
Date:	Thu, 16 Jun 2016 14:25:29 +0200
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Javier Martinez Canillas <javier@....samsung.com>,
	Laxman Dewangan <ldewangan@...dia.com>,
	mturquette@...libre.com, robh+dt@...nel.org, linux@...linux.org.uk
Cc:	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	Javier Martinez Canillas <javier@...hile0.org>
Subject: Re: [PATCH 5/5] ARM: config: Get rid of config COMMON_CLK_MAX77802

On 06/15/2016 05:39 PM, Javier Martinez Canillas wrote:
> Hello Laxman,
> 
> On 06/15/2016 10:13 AM, Laxman Dewangan wrote:
>> The clock driver used by Maxim PMIC MAX77802 is clk-max77686
>> which can be enabled with config CONFIG_COMMON_CLK_MAX77686.
>>
>> Hence the config CONFIG_COMMON_CLK_MAX77802 is not required.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
>> CC: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>> CC: Javier Martinez Canillas <javier@...hile0.org>
>> ---
>>  arch/arm/configs/exynos_defconfig   | 1 -
>>  arch/arm/configs/multi_v7_defconfig | 1 -
> 
> Please split these two changes in separate patches, there are just
> cleanups needed after 1/5 and they can be picked separately.

Not entirely separately. If we do not want to loose max77802 clocks on
defconfigs, then it should go with the same tree or after driver get
merged. I prefer the latter, similar case to 1898994229f8 ("ARM:
multi_v7_defconfig: Switch max77693 to module").

Best regards,
Krzysztof