linux-kernel - Re: [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER

Open Source and information security mailing list archives

Message-ID: <20160616123733.GB23520@phenom.ffwll.local>
Date:	Thu, 16 Jun 2016 14:37:33 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Mark Yao <mark.yao@...k-chips.com>,
	David Airlie <airlied@...ux.ie>,
	Heiko Stuebner <heiko@...ech.de>, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org,
	linux-rockchip@...ts.infradead.org,
	Chris Zhong <zyw@...k-chips.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] drm: rockchip: select DRM_GEM_CMA_HELPER

On Thu, Jun 16, 2016 at 02:27:57PM +0200, Arnd Bergmann wrote:
> The rockchip drm driver started using drm_gem_cma_vm_ops, but that might
> not be part of the kernel, causing the link to fail:
> 
> drivers/gpu/built-in.o:(.data+0xb234): undefined reference to `drm_gem_cma_vm_ops'
> 
> This adds a Kconfig 'select' statement to enable it like the other
> user do.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 80f67cd80add ("drm/rockchip: Use cma gem vm ops")

Applied to drm-misc, thanks.
-Daniel
> ---
>  drivers/gpu/drm/rockchip/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index d30bdc38a760..e48611e83c03 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -2,6 +2,7 @@ config DRM_ROCKCHIP
>  	tristate "DRM Support for Rockchip"
>  	depends on DRM && ROCKCHIP_IOMMU
>  	depends on RESET_CONTROLLER
> +	select DRM_GEM_CMA_HELPER
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_FB_HELPER
>  	select DRM_PANEL
> -- 
> 2.9.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives