linux-kernel - Re: [PATCH V2] PM / OPP: 'UNKNOWN' status of opp-table->shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hPh6nxg3zNGOxYhArBv=hTL9StPL0eCN5zhv=mutZyow@mail.gmail.com>
Date:	Thu, 16 Jun 2016 15:52:07 +0200
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Rafael Wysocki <rjw@...ysocki.net>,
	Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alexandre Courbot <acourbot@...dia.com>
Subject: Re: [PATCH V2] PM / OPP: 'UNKNOWN' status of opp-table->shared

On Thu, Jun 16, 2016 at 3:33 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:
> dev_pm_opp_get_sharing_cpus() returns 0 even in the case where the OPP
> core doesn't know if the table is shared or not. It is working for most
> of the platforms, as the OPP table was never created and we returned
> -ENODEV then.
>
> But in case of one of the platforms (Jetson TK1) at least, the situation
> is a bit different. The OPP table is created (somehow) before
> dev_pm_opp_get_sharing_cpus() is called and so we returned 0. The caller
> of this routine treated that as 'CPUs don't share OPPs' and that had bad
> consequences on performance.
>
> Fix this by creating a converting 'shared_opp' to an enum.
> dev_pm_opp_get_sharing_cpus() returns -EINVAL now in case the status in
> access-unknown, so that the caller can handle it accordingly (cpufreq-dt
> considers that as 'all CPUs share the table').
>
> Fixes: 6f707daa3833 ("PM / OPP: Add dev_pm_opp_get_sharing_cpus()")
> Reported-and-tested-by: Alexandre Courbot <acourbot@...dia.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

I've queued it up, but I rewrote the changelog.

Please check in bleeding-edge.

Thanks!