linux-kernel - Re: [PATCH 1/3] include/linux/mfd/intel_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160616143322.GA4948@dell>
Date:	Thu, 16 Jun 2016 15:33:22 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Bin Gao <bin.gao@...ux.intel.com>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	linux-kernel@...r.kernel.org, ysiyer <yegnesh.s.iyer@...el.com>,
	Ajay Thomas <ajay.thomas.david.rajamanickam@...el.com>,
	Bin Gao <bin.gao@...el.com>
Subject: Re: [PATCH 1/3] include/linux/mfd/intel_soc_pmic.h: add new data
 structures

On Thu, 16 Jun 2016, Lee Jones wrote:

> On Sat, 11 Jun 2016, Bin Gao wrote:
> 
> > This patch adds three new data structures: struct trip_config_map {},
> > struct thermal_irq_map {} and struct pmic_thermal_data {} which are
> > required by some new drivers.
> > 
> > Signed-off-by: ysiyer <yegnesh.s.iyer@...el.com>
> > Signed-off-by: Bin Gao <bin.gao@...el.com>
> > ---
> >  include/linux/mfd/intel_soc_pmic.h | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> 
> Please place the addition of the structs into the patches which use
> them first.

Oh, and when you submit patch-sets, please ensure they are
'threaded'.  Or else they have a tendency to spread themselves to the
four winds in people's Inboxes.

Please fix the subject line too (in all of your patches).  To help
with this you should always do a:

  `git log --oneline -- <subsystem>`

> > diff --git a/include/linux/mfd/intel_soc_pmic.h b/include/linux/mfd/intel_soc_pmic.h
> > index cf619db..7df4302 100644
> > --- a/include/linux/mfd/intel_soc_pmic.h
> > +++ b/include/linux/mfd/intel_soc_pmic.h
> > @@ -21,6 +21,27 @@
> >  
> >  #include <linux/regmap.h>
> >  
> > +struct trip_config_map {
> > +	u16 irq_reg;
> > +	u16 irq_en;
> > +	u16 evt_stat;
> > +	u8 irq_mask;
> > +	u8 irq_en_mask;
> > +	u8 evt_mask;
> > +	u8 trip_num;
> > +};
> > +
> > +struct thermal_irq_map {
> > +	char handle[20];
> > +	int num_trips;
> > +	struct trip_config_map *trip_config;
> > +};
> > +
> > +struct pmic_thermal_data {
> > +	struct thermal_irq_map *maps;
> > +	int num_maps;
> > +};
> > +
> >  struct intel_soc_pmic {
> >  	int irq;
> >  	struct regmap *regmap;
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog