linux-kernel - Re: [PATCH] KEYS: potential uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5864.1466088637@warthog.procyon.org.uk>
Date:	Thu, 16 Jun 2016 15:50:37 +0100
From:	David Howells <dhowells@...hat.com>
To:	jmorris@...ei.org
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, linux-security-module@...r.kernel.org,
	keyrings@...r.kernel.org, torvalds@...ux-foundation.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] KEYS: potential uninitialized variable

David Howells <dhowells@...hat.com> wrote:

> From: Dan Carpenter <dan.carpenter@...cle.com>
> 
> If __key_link_begin() failed then "edit" would be uninitialized.  I've
> added a check to fix that.
> 
> This allows a random user to crash the kernel, though it's quite difficult
> to achieve.  There are three ways it can be done as the user would have to
> cause an error to occur in __key_link():
>
> ...

I forgot to mention, this fixes CVE-2016-4470.

David