linux-kernel - Re: [PATCH v2] mwifiex: fix race condition when downloading firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bn31w515.fsf@kamboji.qca.qualcomm.com>
Date:	Thu, 16 Jun 2016 18:02:30 +0300
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Wei-Ning Huang <wnhuang@...omium.org>
Cc:	Linux-Wireless <linux-wireless@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, akarwar@...vell.com,
	djkurtz@...omium.org
Subject: Re: [PATCH v2] mwifiex: fix race condition when downloading firmware

Wei-Ning Huang <wnhuang@...omium.org> writes:

> The action 'check for winner' and 'download firmware' should be an
> atomic action. This is true for btmrvl driver but not mwmfiex, which
> cause firmware download to fail when the following scenario happens:
>
> 1) mwifiex check winner status: true
> 2) btmrvl check winner status: true, and start downloading firmware
> 3) mwifiex tries to download firmware, but failed because btmrvl is
> already downloading.
>
> This won't happen if 1) and 3) is an atomic action. This patch adds
> sdio_claim/release_host call around those two actions to make sure it's
> atomic.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@...omium.org>

As I accidentally applied v1, I need to drop this one.

-- 
Kalle Valo