linux-kernel - Re: [V2] brcmfmac: fix setting AP channel with new firmwares

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160616150733.8C8546141F@smtp.codeaurora.org>
Date:	Thu, 16 Jun 2016 15:07:33 +0000 (UTC)
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Rafał Miłecki <zajec5@...il.com>,
	Brett Rudley <brudley@...adcom.com>,
	Arend van Spriel <arend@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Hante Meuleman <meuleman@...adcom.com>,
	Pieter-Paul Giesberts <pieterpg@...adcom.com>,
	linux-wireless@...r.kernel.org (open list:BROADCOM BRCM80211
	IEEE802.11n WIRELESS DRIVER),
	brcm80211-dev-list@...adcom.com (open list:BROADCOM BRCM80211
	IEEE802.11n WIRELESS DRIVER),
	netdev@...r.kernel.org (open list:NETWORKING DRIVERS),
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [V2] brcmfmac: fix setting AP channel with new firmwares

Rafał Miłecki wrote:
> Firmware for new chipsets is based on a new major version of code
> internally maintained at Broadcom. E.g. brcmfmac4366b-pcie.bin (used for
> BCM4366B1) is based on 10.10.69.3309 while brcmfmac43602-pcie.ap.bin was
> based on 7.35.177.56.
> 
> Currently setting AP 5 GHz channel doesn't work reliably with BCM4366B1.
> When setting e.g. 36 control channel with VHT80 (center channel 42)
> firmware may randomly pick one of:
> 1) 52 control channel with 58 as center one
> 2) 100 control channel with 106 as center one
> 3) 116 control channel with 122 as center one
> 4) 149 control channel with 155 as center one
> 
> It seems new firmwares require setting AP mode (BRCMF_C_SET_AP) before
> specifying a channel. Changing an order of firmware calls fixes the
> problem. This requirement resulted in two separated "chanspec" calls,
> one in AP code path and one in P2P path.
> 
> This fix was verified with BCM4366B1 and tested for regressions on
> BCM43602.
> 
> Signed-off-by: Rafał Miłecki <zajec5@...il.com>

Thanks, 1 patch applied to wireless-drivers-next.git:

8707e08dbc1f brcmfmac: fix setting AP channel with new firmwares

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9138883/